feat(ios): reviving PR #12411 for ios background tasks #14142
Conversation
AbdullahFaqeir
changed the title
|
@hansemannn @m1ga if we can check this |
|
@AbdullahFaqeir I think you are still on a different branch as I can see some of your "ios dark mode icons" stuff in there. |
@m1ga already cleaned up |
|
checked the changed files: it still has https://github.com/tidev/titanium-sdk/pull/14142/files#diff-2c47f46b98744ab36764749bd8937002f06e1293a9b41d4ff2e12c1790e47d77 |
|
I only reverted the file to it's original content from the main repo |
|
That part (and the other file you reverted already) is from your other PR: https://github.com/tidev/titanium-sdk/pull/14137/files . It looks like you didn't start from the master branch to start the PR but from this branch |
| ENSURE_STRING(args[@"identifier"]); | ||
| ENSURE_STRING(args[@"type"]); | ||
|
|
||
| if ([TiUtils isIOSVersionLower:@"13.0"]) { |
There was a problem hiding this comment.
The Titanium SDK has a current minimum of iOS 13 already, so you can remove this
| @@ -433,6 +433,10 @@ - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:( | |||
| // Create application support directory if not exists | |||
| [self createDefaultDirectories]; | |||
|
|
|||
| if ([TiUtils isIOSVersionOrGreater:@"13.0"]) { | |||
There was a problem hiding this comment.
Remove guard, not necessary
| @@ -1083,20 +1087,26 @@ - (void)applicationDidEnterBackground:(UIApplication *)application | |||
|
|
|||
| [[NSNotificationCenter defaultCenter] postNotificationName:kTiPausedNotification object:self]; | |||
|
|
|||
| if ([TiUtils isIOSVersionOrGreater:@"13.0"]) { | |||
| } | ||
| } | ||
|
|
||
| - (void)handleBGTask:(BGTask *)task |
There was a problem hiding this comment.
| - (void)handleBGTask:(BGTask *)task | |
| - (void)handleBackgroundTask:(BGTask *)task |
| // Fo processing task, if it is not completed in time then only submit it again. | ||
| [self submitTaskForIdentifier:task.identifier]; | ||
| } | ||
| [task setTaskCompletedWithSuccess:false]; |
There was a problem hiding this comment.
Use proper Objc types
| [task setTaskCompletedWithSuccess:false]; | |
| [task setTaskCompletedWithSuccess:NO]; |
| NSDictionary *bgTask = nil; | ||
| for (NSDictionary *backgroundTask in backgroundTasks) { | ||
| if (backgroundTask[@"identifier"] == identifier) { | ||
| bgTask = backgroundTask; |
There was a problem hiding this comment.
Simply return here, so you save the extra assignment. Return nil by default after the loop
| } |
There was a problem hiding this comment.
Unrelated change (add extra line again)
| @@ -2391,6 +2391,7 @@ | |||
| DEVELOPMENT_TEAM = ""; | |||
| ENABLE_BITCODE = NO; | |||
| "ENABLE_HARDENED_RUNTIME[sdk=macosx*]" = YES; | |||
| EXCLUDED_ARCHS = ""; | |||
| @@ -2454,6 +2455,7 @@ | |||
| ENABLE_BITCODE = NO; | |||
| "ENABLE_HARDENED_RUNTIME[sdk=macosx*]" = YES; | |||
| ENABLE_NS_ASSERTIONS = NO; | |||
| EXCLUDED_ARCHS = ""; | |||
| @@ -1,68 +1,117 @@ | |||
| { | |||
| "images" : [ | |||
| { | |||
There was a problem hiding this comment.
Restore all change in this file
This PR is solely to revive PR #12411