Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly dt_squash() args in lead()/lag() #442

Merged
merged 3 commits into from
Aug 19, 2023
Merged

Properly dt_squash() args in lead()/lag() #442

merged 3 commits into from
Aug 19, 2023

Conversation

markfairbanks
Copy link
Collaborator

Closes #441

eutwt
eutwt approved these changes Aug 19, 2023
View reviewed changes
Copy link
Collaborator

@eutwt eutwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@markfairbanks markfairbanks merged commit 774f00d into main Aug 19, 2023
12 checks passed
@markfairbanks markfairbanks deleted the dt_squash-shift-args branch August 19, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eutwt eutwt eutwt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lead / lag within function with .data$
2 participants
@markfairbanks @eutwt