Bump deprecations #6138
Open
Bump deprecations #6138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasp85
reviewed
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not fix an issue, but I see it as regular maintenance.
Briefly, it converts
deprecate_warn0()tolifecycle::deprecate_stop()for functions/arguments that were deprecated prior to ggplot 3.3.0.It converts
deprecate_soft0()todeprecate_warn0()for functions/arguments that were deprecated up to ggplot2 3.2.0 and removes examples.I thought 5 years to be an OK horizon for deprecation warnings and I felt it was time to stop allowing things from the previous major version. Happy to make these timelines shorter though :)