Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate autoware_auto_msgs to autoware_msgs #313

Merged
merged 18 commits into from
Oct 16, 2024

Conversation

lchojnack
Copy link
Contributor

@lchojnack lchojnack commented Jun 7, 2024

  • I’ve updated the documentation

  • I’ve tested the PR with the latest Autoware and it works as expected

    screen_recorder-2024-06-07_15.49.19.webm
  • I’ve tested the AWSIM on Windows without Autoware and it works as expected
    autoware_msgs_windows

  • I’ve tested the AWSIM with ss2 on branch RJD-736/autoware_msgs_support following the instruction and it works as expected

@lchojnack lchojnack self-assigned this Jun 7, 2024
@lchojnack lchojnack marked this pull request as ready for review June 7, 2024 14:14
@mackierx111 mackierx111 marked this pull request as draft June 11, 2024 01:22
@mackierx111
Copy link
Collaborator

Change to draft until Autoware side also supports new msg

@Goldob
Copy link
Contributor

Goldob commented Aug 1, 2024

The branch has been updated to current main and the PR is ready for review.

@Goldob Goldob marked this pull request as ready for review August 1, 2024 07:22
@mackierx111
Copy link
Collaborator

mackierx111 commented Aug 22, 2024

I ran this branch with the awsim-stable-update branch in my local environment. As a result, Autoware was not able to use the camera image, which is under investigation.

@lchojnack
Copy link
Contributor Author

I've updated the PR with the latest main branch
The PR is working with awsim-stable-update

video-2024-09-12-12-21-55.mp4

@mackierx111
Copy link
Collaborator

I have completed checking this pull request.
but I had to follow a few steps, which I will note here.

  1. Run setup-dev-env.sh with awsim-stable-update branch. (all yes)
  2. Install nvidia-driver-550 in Additional Driver -> Software & Updates and lower the version from 560
  3. Apply two PRs to Autoware. #8663 fix(reaction_analyzer): fix include hierarchy of tf2_eigen, #196 fix(nebula_hw_interfaces): add missing iomanip header
  4. Then build Autoware as usual.

@mackierx111
Copy link
Collaborator

image (43)

It no longer outputs more than 15 km/h. I am asking the Autoware developer if this is intentional.

@mackierx111
Copy link
Collaborator

It was intentional.
autowarefoundation/autoware_launch#763

Copy link
Collaborator

@mackierx111 mackierx111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mackierx111 mackierx111 merged commit 7bac9f1 into main Oct 16, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants