This repository has been archived by the owner on Sep 16, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
taichiH
force-pushed
the
move-elevation_map_loader
branch
from
November 30, 2021 02:46
cd7da35
to
1b09ca2
Compare
merge after #745 |
build and test is failed because tier4/AutowareArchitectureProposal_api_msgs#1 hasn't been merged yet. |
kosuke55
reviewed
Dec 1, 2021
perception/object_segmentation/elevation_map_loader/launch/elevation_map_loader.launch.xml
Outdated
Show resolved
Hide resolved
Would you please add following params to
|
kosuke55
reviewed
Dec 1, 2021
kosuke55
previously approved these changes
Dec 1, 2021
perception/object_segmentation/elevation_map_loader/src/elevation_map_loader_node.cpp
Outdated
Show resolved
Hide resolved
taichiH
force-pushed
the
move-elevation_map_loader
branch
from
December 2, 2021 06:51
d2330c0
to
c07bb7c
Compare
taichiH
force-pushed
the
move-elevation_map_loader
branch
from
December 3, 2021 01:35
c07bb7c
to
4c91871
Compare
kosuke55
approved these changes
Dec 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
move elevation_map_loader from map_loader to create new elevation_map_loader as a member of perception module.
Review Procedure
This PR depend on these pull requests
please merge this pr with
Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks