Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(aip_x2): update lidar angle range #187

Merged
merged 1 commit into from
Nov 22, 2023
Merged

chore(aip_x2): update lidar angle range #187

merged 1 commit into from
Nov 22, 2023

Conversation

0x126
Copy link
Contributor

@0x126 0x126 commented Nov 20, 2023

Update LiDAR range

TomohitoAndo
TomohitoAndo approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@TomohitoAndo TomohitoAndo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed that the values are the same as previous one. 714739e

@TomohitoAndo
Copy link
Contributor

I think it is okay if this is confirmed with the real vehicle.

@0x126
Copy link
Contributor Author

0x126 commented Nov 22, 2023

Confirmed by actual vehicle on 11/27

@0x126 0x126 merged commit b817cab into tier4/universe Nov 22, 2023
9 of 10 checks passed
@0x126 0x126 deleted the chore/aip_x2/update-qt-range branch November 22, 2023 07:47
0x126 added a commit that referenced this pull request Nov 28, 2023
@0x126
chore(aip_x2): update lidar angle range (#187)
d73ec18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomohitoAndo TomohitoAndo TomohitoAndo approved these changes

@saka1-s saka1-s Awaiting requested review from saka1-s

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0x126 @TomohitoAndo