Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nebula_node_container): enhance logging #199

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Jan 19, 2024

Enhance logging of nebula_node_container.

  • Add glog_component in nebula_node_container so that all the LiDAR preprocessing container will have glog enabled
  • Change logging configuration from "screen" to "both" so that the log will be written to the log file as well as terminal

Related: autowarefoundation/sample_sensor_kit_launch#86

@kminoda
Copy link
Contributor Author

kminoda commented Jan 19, 2024

@knzo25 Hi, would you mind reviewing this PR?

@kminoda
Copy link
Contributor Author

kminoda commented Jan 29, 2024

@knzo25 Friendly ping 🙏

Copy link
Contributor

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kminoda kminoda merged commit 4259268 into tier4/universe Jan 29, 2024
10 of 11 checks passed
@kminoda kminoda deleted the chore/enhance_logging branch January 29, 2024 04:32
kminoda added a commit that referenced this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants