feat(common_sensor_launch): add distortion corrector param #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vividf <[email protected]>
|
@knzo25 |
|
@knzo25 |
knzo25
approved these changes
Jul 3, 2024
knzo25
pushed a commit
that referenced
this pull request
Sep 12, 2024
* feat: add distortion corrector param Signed-off-by: vividf <[email protected]> * ci(pre-commit): autofix --------- Signed-off-by: vividf <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
TomohitoAndo
added a commit
that referenced
this pull request
Sep 13, 2024
* fix(lidar): update PTP settings for new PTP architecture * fix(lidar): set FoVs to their desired (no added padding for correction) values as Nebula handles this now * chore(lidar): change parameters and node name to nebula/develop versions * fix(nebula_node_container): add multicast_ip parameter * fix(nebula_node_container): add point_filters parameter * hotfix(nebula_container_launch): ring outlier filter segfaults, disable it for now * ci(pre-commit): autofix * feat(common_sensor_launch): add distortion corrector param (#247) * feat: add distortion corrector param Signed-off-by: vividf <[email protected]> * ci(pre-commit): autofix --------- Signed-off-by: vividf <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * chore: add parameter for distortion corrector --------- Signed-off-by: vividf <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Yi-Hsiang Fang (Vivid) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR: autowarefoundation/autoware.universe#7137 removes the default parameters from the distortion correction node and add the parameters file for the distortion node.
As the default parameters are removed, nebula_node_container.launch.py needs to load the parameters from yaml file.
test with
ros2 launch autoware_launch logging_simulator.launch.xml map_path:=$HOME/autoware_map/sample-rosbag vehicle_model:=jpntaxi sensor_model:=aip_xx1 vehicle_id:=2