revert: feat(global_parameter_loader): add gtest to global parameter loader (backport #6872) #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loader (autowarefoundation#6872) Revert "feat(global_parameter_loader): add gtest to global parameter loader (…" This reverts commit dfec62a.
|
リリース待つ、という判断もありますが、GW挟んでリリースがしばらく行われないので、マージします。 |
tkimura4
approved these changes
Apr 25, 2024
|
@Mergifyio backport tier4/main |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
…loader (backport autowarefoundation#6872) (#1274) revert: feat(global_parameter_loader): add gtest to global parameter loader (autowarefoundation#6872) Revert "feat(global_parameter_loader): add gtest to global parameter loader (…" This reverts commit dfec62a. (cherry picked from commit e5196bc)
7 tasks
tkimura4
pushed a commit
that referenced
this pull request
Apr 25, 2024
…loader (backport autowarefoundation#6872) (backport #1274) (#1275) revert: feat(global_parameter_loader): add gtest to global parameter loader (backport autowarefoundation#6872) (#1274) revert: feat(global_parameter_loader): add gtest to global parameter loader (autowarefoundation#6872) Revert "feat(global_parameter_loader): add gtest to global parameter loader (…" This reverts commit dfec62a. (cherry picked from commit e5196bc) Co-authored-by: Hiroki OTA <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
下記コミットをrevertする
dfec62a
理由は以下の通り
Related links
https://star4.slack.com/archives/C03QU7K50D8/p1714022756814529
Tests performed
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.