fix(ndt_scan_matcher): update function call from Laplace to laplace #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: N-Eiki <[email protected]>
N-Eiki
requested review from
anhnv3991,
KYabuuchi,
Motsu-san,
RyuYamamoto,
SakodaShintaro,
TaikiYamada4 and
YamatoAndo
as code owners
|
N-Eiki
changed the title
N-Eiki
changed the title
N-Eiki
changed the title
N-Eiki
changed the title
YamatoAndo
approved these changes
Aug 9, 2024
|
@N-Eiki |
|
autoware.universe側の変更という意味だと autoware.universeとndt_ompのバージョンが対応ついてれば大丈夫だと思っていますが、 このtier4/mainというブランチのsync頻度やタイミングを把握していないのでどう対応するかはお任せします |
|
@N-Eiki @SakodaShintaro そもそもこのPRの目的は、pilot-auto.xx1の最新mainブランチでv0.32.0相当を動かすことなので、v0.32.0以上のことはしなくてOKです。つまり、pilot-auto.xx1側のmainブランチのテストでは、ndt_ompを古いものにしてテストして、このPRはクローズしたいです。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
tier4/ndt_omp#59
この修正が適用されていなかったためndt_scan_matcherのbuildで落ちてしまっていた
Related links
Parent Issue:
How was this PR tested?
build and test in evaluator
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.