forked from autowarefoundation/autoware.universe
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lane_change, avoidance): add force execution and cancel #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…conditions (autowarefoundation#8094) * add force execution for static obstacle avoidance Signed-off-by: Go Sakayori <[email protected]> * fix Signed-off-by: Go Sakayori <[email protected]> * erase unused function in RTC interface Signed-off-by: Go Sakayori <[email protected]> * refactor with lamda function Signed-off-by: Go Sakayori <[email protected]> * fix rtc_interface Signed-off-by: Go Sakayori <[email protected]> * add warn throtthle and move code block Signed-off-by: Go Sakayori <[email protected]> * fix Signed-off-by: Go Sakayori <[email protected]> --------- Signed-off-by: Go Sakayori <[email protected]> Signed-off-by: Go Sakayori <[email protected]>
* fix Signed-off-by: Go Sakayori <[email protected]> * fix format Signed-off-by: Go Sakayori <[email protected]> --------- Signed-off-by: Go Sakayori <[email protected]> Signed-off-by: Go Sakayori <[email protected]>
…towarefoundation#8131) add force execution conditions Signed-off-by: Go Sakayori <[email protected]>
…oundation#8221) add function to check for deactivation Signed-off-by: Go Sakayori <[email protected]>
…ation#8235) transfer to cancel state when force deactivated Signed-off-by: Go Sakayori <[email protected]>
…on#8288) * add force cancel function Signed-off-by: Go Sakayori <[email protected]> * fix format Signed-off-by: Go Sakayori <[email protected]> * fix json schema Signed-off-by: Go Sakayori <[email protected]> * fix spelling Signed-off-by: Go Sakayori <[email protected]> * fix Signed-off-by: Go Sakayori <[email protected]> --------- Signed-off-by: Go Sakayori <[email protected]> Signed-off-by: Go Sakayori <[email protected]>
go-sakayori
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
TakaHoribe,
takayuki5168,
TomohitoAndo,
tkimura4,
zulfaqar-azmi-t4 and
taikitanaka3
as code owners
August 13, 2024 05:27
4 tasks
shmpwk
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this PR force execution and force cancel is enabled via FOA for xx1.
Easy explanation about the functions in FOA.
FOAによる介入手法一覧
Related links
tier4/autoware_launch#538
How was this PR tested?
Could engage in PSim.
Notes for reviewers
None.
Interface changes
ROS Parameter Changes
Additions and removals
cancel.force.duration
double
2.0
Effects on system behavior
None.