feat(pointcloud_preprocessor): add hysteresis to concat diag #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove diagnostics_updater * add counter * change node name * rename * style(pre-commit): autofix --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: kotaro-hihara <[email protected]>
kotaro-hihara
requested review from
badai-nguyen,
drwnz,
knzo25,
kyoichi-sugahara,
miursh,
vividf,
YoshiRi and
yukkysaito
as code owners
kotaro-hihara
removed request for
knzo25,
yukkysaito,
YoshiRi,
kyoichi-sugahara,
drwnz,
miursh,
badai-nguyen and
vividf
|
|
この対策は適切ではなさそうなので一旦キャンセル。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-picked add hysteresis diag(PR) in beta/v0.19.1
Conflicts were resolved. (node name concatnate_data is still the same)
Fixed to set diag to warn if concat is NG consecutively for 3 frames.
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.