Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(goal_planner): always run fixed_goal_planner #805

Merged
merged 4 commits into from
Sep 17, 2023

Conversation

kosuke55
Copy link

@kosuke55 kosuke55 commented Sep 6, 2023

Description

[X2][beta/v2.2.1] goal poseが固定してリサンプルされていない(操舵ガタつきに影響)
https://tier4.atlassian.net/browse/RT0-28869
の修正

#804 での修正内容に加えて
start planner -> goal planner(keep last)でstart planner起動時にもゴールにつなげる

image

Related links

Tests performed

psim

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

satoshi-ota and others added 3 commits September 6, 2023 18:43
* feat(interface): add new option last_keep

Signed-off-by: satoshi-ota <[email protected]>

* feat(planner_manager): keep last module

Signed-off-by: satoshi-ota <[email protected]>

* update param config

Signed-off-by: kosuke55 <[email protected]>

---------

Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: kosuke55 <[email protected]>
Co-authored-by: kosuke55 <[email protected]>
…owarefoundation#4785)

* feat(behavior_path_planner): add always executable module option

Signed-off-by: kosuke55 <[email protected]>

* fix conditions

Signed-off-by: kosuke55 <[email protected]>

* rename itr

Signed-off-by: kosuke55 <[email protected]>

* Update planning/behavior_path_planner/src/planner_manager.cpp

Co-authored-by: Satoshi OTA <[email protected]>

* Update planning/behavior_path_planner/src/planner_manager.cpp

Co-authored-by: Satoshi OTA <[email protected]>

* Update planning/behavior_path_planner/src/planner_manager.cpp

Co-authored-by: Satoshi OTA <[email protected]>

* fix candidate break

Signed-off-by: kosuke55 <[email protected]>

* Revert "fix candidate break"

This reverts commit 0071bbd.

* remove continue

Signed-off-by: kosuke55 <[email protected]>

* check manager_ptr->isAlwaysExecutableModule first

Signed-off-by: kosuke55 <[email protected]>

* common similar process

Signed-off-by: kosuke55 <[email protected]>

* fix getRequestModules

Signed-off-by: kosuke55 <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
Co-authored-by: Satoshi OTA <[email protected]>
Copy link

@mkuri mkuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed it on psim.
LGTM.

@mkuri mkuri changed the title feat(goal_planner): always run fixed_goal_planner feat(goal_planner): always run fixed_goal_planner Sep 17, 2023
@mkuri mkuri merged commit 4f35db8 into beta/v0.11.0 Sep 17, 2023
12 of 13 checks passed
@mkuri mkuri deleted the fix/fixed_goal_v0.11.0 branch September 17, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants