Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unnecessary workflows #330

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

takayuki5168
Copy link

@takayuki5168 takayuki5168 commented Feb 29, 2024

Description

Removed unnecessary workflows which are not used now

  • .github/workflows/create-awf-latest.yml
    • Already disabled. I created this before, but instead, sync-awf-latest.yml is used.
  • Sync for reference design
    • Already disabled
    • .github/workflows/sync-awf-latest-s1.yaml
    • .github/workflows/sync-awf-latest-x1.yaml
    • .github/workflows/sync-awf-latest-x2.yaml
    • .github/workflows/sync-awf-latest-xx1.yaml

Tests performed

No need

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <[email protected]>
@tkimura4
Copy link
Collaborator

.github/workflows/sync-tier4-upstream.yaml
Already disabled and not used https://github.com/tier4/autoware_launch/actions/workflows/sync-tier4-upstream.yaml

I think there is no need to delete this workflow, as it is intended for use in the repository created by forking autoware_launch.

Signed-off-by: Takayuki Murooka <[email protected]>
@takayuki5168
Copy link
Author

@tkimura4
Thank you for the comment. I added it in the top of the yaml file.

Copy link
Collaborator

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takayuki5168 takayuki5168 merged commit 5ade107 into tier4/main Feb 29, 2024
10 checks passed
@takayuki5168 takayuki5168 deleted the chore/remove-unnecessary-workflows branch February 29, 2024 14:38
t4-adc pushed a commit that referenced this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants