Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lane_change): parameter update (#1115) #547

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

zulfaqar-azmi-t4
Copy link

Description

cherry-pick to relax lane change parameters

fix(lane_change): parameter update #1115
These parameters is tested in experiment on August 8th.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@zulfaqar-azmi-t4
Copy link
Author

zulfaqar-azmi-t4 commented Aug 16, 2024

@shmpwk @Naophis
I am relaxing lane change safety check params, and I've tested them for degradation as well as in the experiment on August 8th.
During the test, no issue appears, and lane change cancel was reduced.

However, further observation is still needed.

I will leave up to you guys to decide whether to test them first or just merge them.

@shmpwk
Copy link

shmpwk commented Aug 20, 2024

@zulfaqar-azmi-t4
Thank you so much! You mean you tested with xx1 and it might be better not to apply this to x2?

@Naophis
こちらはマージして、X2のsync時に取り入れるかご判断いただきたいです。

@zulfaqar-azmi-t4
Copy link
Author

zulfaqar-azmi-t4 commented Aug 20, 2024

@shmpwk CC @Naophis
I mean I tested it in XX1, and I'm satisfied with the results and suggest for XX1 and X2 to merged them.

However, further observation is still needed.

About this statement, because I just tested it just within a day, I am suggesting the XX1 and X2 team to test them first to see if they are safe.

@shmpwk shmpwk merged commit 97e17f4 into beta/v0.29.0 Aug 20, 2024
10 checks passed
@shmpwk shmpwk deleted the hotfix/beta/v0.29.0/relaxing-lc-params branch August 20, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants