-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: class to edit message_context #532
Conversation
Signed-off-by: ISP akm <[email protected]>
Signed-off-by: ISP akm <[email protected]>
@xygyo77 |
Since it is an alternative to the AssignContextReader class, I assume it is covered in caret_analyze/src/test/architecture/test_architecture.py.
|
Signed-off-by: ISP akm <[email protected]>
The above test case was able to test for this change. It seems that we don't need to add any additional tests. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[compare] ========== Result ==========
[compare] 1/3 file existence matches
[compare] OK. file existence matches
[compare] 2/3 yaml files
[compare] OK. yaml matches
[compare] 3/3 PNG files
[compare] OK. PNG matches
[compare] ====== ALL OK ==============
LGTM
Description
AssignContextReader is a class that inherits from ArchitectureReader, but it implements almost none of ArchitectureReader's functions, making the code difficult to understand.
Delete the AssignContextReader class and change the implementation to be more in line with the actual situation.
Related links
https://tier4.atlassian.net/browse/RT2-1845
Notes for reviewers
Pre-review checklist for the PR author
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.