Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: class to edit message_context #532

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

xygyo77
Copy link
Contributor

@xygyo77 xygyo77 commented Sep 24, 2024

Description

AssignContextReader is a class that inherits from ArchitectureReader, but it implements almost none of ArchitectureReader's functions, making the code difficult to understand.
Delete the AssignContextReader class and change the implementation to be more in line with the actual situation.

Related links

https://tier4.atlassian.net/browse/RT2-1845

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR has been properly tested.
  • The PR has been reviewed.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • (Optional) The PR has been properly tested with CARET_report verification.
  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@xygyo77 xygyo77 requested a review from ymski September 24, 2024 02:05
Signed-off-by: ISP akm <[email protected]>
@ymski
Copy link
Contributor

ymski commented Sep 25, 2024

@xygyo77
Could you create a test for the ContextUpdater class?

@xygyo77
Copy link
Contributor Author

xygyo77 commented Sep 25, 2024

@xygyo77 Could you create a test for the ContextUpdater class?

Since it is an alternative to the AssignContextReader class, I assume it is covered in caret_analyze/src/test/architecture/test_architecture.py.

  • test_update_message_context()
  • test_remove_variable_passing()

@ymski
Copy link
Contributor

ymski commented Sep 25, 2024

@xygyo77 Could you create a test for the ContextUpdater class?

Since it is an alternative to the AssignContextReader class, I assume it is covered in caret_analyze/src/test/architecture/test_architecture.py.

  • test_update_message_context()
  • test_remove_variable_passing()

The above test case was able to test for this change. It seems that we don't need to add any additional tests. Thanks.

Copy link
Contributor

@ymski ymski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@miyakoshi-dev miyakoshi-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[compare] ========== Result ==========
[compare] 1/3 file existence matches
[compare] OK. file existence matches
[compare] 2/3 yaml files
[compare] OK. yaml matches
[compare] 3/3 PNG files
[compare] OK. PNG matches
[compare] ====== ALL OK ==============
LGTM

@xygyo77 xygyo77 merged commit bf6ab9e into tier4:main Sep 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants