Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify gpiod sensor trigger implementation #26

Open
wants to merge 1 commit into
base: feat/use_libgpiod
Choose a base branch
from

Conversation

bgilby59
Copy link

@bgilby59 bgilby59 commented Dec 7, 2023

PR Type

  • Improvement

Description

This PR refactors sensor_trigger gpiod implementation to remove unnecessary code, correct misleading comments, and follow gpiod naming conventions for gpio manipulation.

Review Procedure

  • Build edge-auto-jetson
  • Run edge-auto-jetson with perception:=false
  • Check trigger_time and image_raw ROS2 topics with ros2 topic hz <topic_name>

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@bgilby59 bgilby59 requested review from manato and drwnz December 7, 2023 04:32
@bgilby59 bgilby59 force-pushed the refactor/simplify-libgpiod-implementation branch from 4177c90 to c916f3c Compare December 7, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant