Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(autoware_iv_external_api_adaptor): update component_interface_utils dependency #127

Merged

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Oct 29, 2024

PR Type

  • Bug Fix

Related Links

autowarefoundation/autoware.universe#9092

Description

Update dependency for component_interface_utils

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s).
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@esteve
Copy link
Contributor Author

esteve commented Nov 4, 2024

@isamu-takagi could you review this PR when you have a moment? The CI is failing for now because of the dependency being renamed, but the changes are minimal. Thanks.

Copy link
Collaborator

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isamu-takagi isamu-takagi enabled auto-merge (squash) November 4, 2024 13:37
@xmfcx
Copy link

xmfcx commented Nov 4, 2024

@esteve @isamu-takagi could you rerun the failed CI? I don't have the permission.

@isamu-takagi isamu-takagi merged commit d9ef8aa into tier4:tier4/universe Nov 4, 2024
8 checks passed
@esteve esteve deleted the prefix-component_interface_utils branch November 4, 2024 16:23
@esteve
Copy link
Contributor Author

esteve commented Nov 4, 2024

@isamu-takagi @xmfcx thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants