Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fast random projection gsql - updates to parameter implementation #140

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jkerney
Copy link

@jkerney jkerney commented Sep 16, 2023

PR Summary

This PR addresses two bugs in query tg_fastRP.gsql.

  1. Parameter choose_k ineffective
  • Initially implemented in commit 33bde5e, the GSQL for this parameter was removed in commit 4a12d01.
  • This bug has been resolved by reintroducing the GSQL from commit 33bde5e.
  1. Incorrect zero values when print_results = TRUE
  • This occurs because of the line s.@final_embedding_arr.clear(), which clears the accumulator values before printing.
  • This bug has been resolved by removing s.@final_embedding_arr.clear(). This line was likely introduced to minimize memory consumption. However, its impact is likely minimal as it occurs towards the end of the script.

Additional Information

  • Testing: The changes have been tested locally.
  • Impact on Existing Features: No impact on existing features or new dependencies introduced.

Feedback Request

Bug fix for print_results parameter. When this parameter is set to TRUE, the script should print all node embeddings results. However all node embeddings will be zero due to the line s.@final_embedding_arr.clear(). The fix is to remove this line. Since this line is towards the end in the code, impact to memory consumption should be minimal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant