Adding support for KSZ9477 managed ethernet switch for saluki-v3 #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaitine
force-pushed
the
ksz9477_phy
branch
5 times, most recently
from
95bd1b9
to
6cf714f
Compare
jlaitine
changed the title
jlaitine
commented
Sep 4, 2023
jlaitine
force-pushed
the
ksz9477_phy
branch
from
6cf714f
to
3e1f25c
Compare
jlaitine
commented
Sep 4, 2023
jlaitine
commented
Sep 4, 2023
jlaitine
commented
Sep 4, 2023
jlaitine
commented
Sep 4, 2023
jlaitine
force-pushed
the
ksz9477_phy
branch
from
3e1f25c
to
faa61a6
Compare
pussuw
approved these changes
Sep 4, 2023
drivers/net/ksz9477_i2c.c
Outdated
| ****************************************************************************/ | ||
|
|
||
| #include <nuttx/config.h> | ||
| #include <debug.h> |
There was a problem hiding this comment.
I don't think this header is needed here?
drivers/net/ksz9477_reg.h
Outdated
|
|
||
| /* Port registers */ | ||
|
|
||
| #define KSZ9477_PORT_REG(port,x) ((((uint16_t)port) << 12) | (x)) |
There was a problem hiding this comment.
Yes, definitely. I wil also change x -> reg for clarity
jlaitine
force-pushed
the
ksz9477_phy
branch
2 times, most recently
from
772b16a
to
3138394
Compare
pussuw
approved these changes
Sep 5, 2023
jlaitine
force-pushed
the
ksz9477_phy
branch
4 times, most recently
from
0c9b09d
to
5629997
Compare
|
I'll try upstreaming before merging this in |
Signed-off-by: Jukka Laitinen <[email protected]>
This adds initialization of the ksz9477 switch when used instead of a PHY, directly connected to SGMII Signed-off-by: Jukka Laitinen <[email protected]>
jlaitine
force-pushed
the
ksz9477_phy
branch
from
5629997
to
c9377d7
Compare
|
This change is now upstreamed, and this is direct cherry-pick from upstream. Merging-> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding code for saluki-v3 ethernet switch configuration.
Tested to be working on saluki-v3