arch/risc-v/src/mpfs/mpfs_i2c.c: Clean up using priv->status and STOP… #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaitine
force-pushed
the
fix_mpfs_i2c
branch
from
5099809
to
c835c37
Compare
eenurkka
reviewed
Sep 11, 2023
arch/risc-v/src/mpfs/mpfs_i2c.c
Outdated
| /* FPGA driver terminates all transactions with STOP sent irq | ||
| * if there has been no errors, the transfer succeeded. | ||
| * Due to the IP bug that extra data & STOPs can be sent after | ||
| * the actual transaction, filter out any extra stops wit |
jlaitine
commented
Sep 11, 2023
… interrupts - There are occasional extra STOPs being sent due to an IP bug when using an FPGA based I2C. Add a flag "inflight" to mask out extra STOP interrupts when using the FPGA based implementation - There are no MPFS_I2C_ST_STOP_SENT irq's "initally". It is just already either success or still in progress Signed-off-by: Jukka Laitinen <[email protected]>
jlaitine
force-pushed
the
fix_mpfs_i2c
branch
from
c835c37
to
bcf02ad
Compare
eenurkka
approved these changes
Sep 11, 2023
|
Positive test results, seems to also fix the issue where "reboot" command gets stuck at i2c devices sometimes for long time(out)s. Merging and up-streaming |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… interrupts
Summary
This fixes some issues in barometer initialization at boot
Impact
Testing
On-table