arch/arm64/src/imx9/imx9_lpi2c.c: Cleanups and error fixes #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pussuw
reviewed
Sep 11, 2024
pussuw
approved these changes
Sep 11, 2024
jlaitine
force-pushed
the
imx9_i2c_cleanup
branch
from
7128581
to
1b4e99b
Compare
Clean up the interrupt-driven logic in the driver; handle error cases properly, remove dead code and simplify logic. Signed-off-by: Jukka Laitinen <[email protected]>
jlaitine
force-pushed
the
imx9_i2c_cleanup
branch
from
1b4e99b
to
81cac7f
Compare
pussuw
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up the interrupt-driven logic in the driver; handle error cases properly, remove dead code and simplify logic.
Summary
Fixes a load of issues with imx9 interrupt-driven i2c driver
Impact
Testing
on-desk