Imx9 i2c fixes #284
Merged
Imx9 i2c fixes #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaitine
force-pushed
the
imx9_i2c_fixes
branch
from
ba2eea6
to
e6ef076
Compare
pussuw
approved these changes
Sep 18, 2024
jlaitine
force-pushed
the
imx9_i2c_fixes
branch
from
a406b4c
to
aea511f
Compare
Both RX and TX interrupts can be enabled after the setup of the transfer; the TX interrupt must be enabled after queuing the first byte as done before. It is not possible to miss the RX interrupts, as it pends as long as the byte gets read from the FIFO When starting the TX, the first byte can be queued instantly, it won't be sent out to the bus if there is NACK to the address. This also prevents spurious TX interrupts in error cases, since the TX queue is not empty after initiating a transfer. In some error cases controller sends STOP by itself even if AUTOSTOP is disabled. It is better to tell the controller to ABORT, which will also generate STOP only when needed. Signed-off-by: Jukka Laitinen <[email protected]>
Signed-off-by: Jukka Laitinen <[email protected]>
Signed-off-by: Jukka Laitinen <[email protected]>
jlaitine
force-pushed
the
imx9_i2c_fixes
branch
from
aea511f
to
31a4e89
Compare
pussuw
approved these changes
Sep 20, 2024
|
Now I have tested this as good as I possibly can. The driver may still fail due to nuttx tick timer being broken, made a new JIRA about that. Increasing the timeout to min 2 ticks removes all the issues, but I didn't do that. Let's fix the tick timer instead. Verfifed with logic analyzer that there are no timing issues and made a several hours test with all the sensors running. Also made some testing with tampering with GPS module cable causing a load of errors on the bus. The driver seems to also recover quite nicely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some more robust error handling to the imx9 i2c