ksz9477: MMD indirect access check fix #287
Merged
+49
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnippula
force-pushed
the
ksz9477-mmd-check-fix
branch
2 times, most recently
from
f2f99bb
to
7b20aa2
Compare
Instead of verifying MMD indirect access by checking EEE ADVERTISEMENT register has value 0x6 (which may be changed), the verification is done by write and check LED MODE register. 1. Backup current LED_MODE register value 2. Write value Single-LED mode (0x10) to LED_MODE 3. Read LED_MODE register and verify it returns value 0x10 4. Write original (backup) value to LED_MODE
jpaali
approved these changes
Sep 20, 2024
jnippula
force-pushed
the
ksz9477-mmd-check-fix
branch
from
7b20aa2
to
3c2baf3
Compare
jpaali
approved these changes
Sep 20, 2024
|
Modified code a bit to first read and backup the original value, just in case it is set somewhere else. |
jpaali
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of verifying MMD indirect access by checking EEE ADVERTISEMENT register has value 0x6 (which may be changed), the verification is done by write and check LED MODE register.
1. Backup current LED_MODE register value
2. Write value Single-LED mode (0x10) to LED_MODE
3. Read LED_MODE register and verify it returns value 0x10
4. Write original (backup) value to LED_MODE