Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DP7417 C++ Implementation of Secure MAVLink proxy on device-side #563

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

kjyrinki-unikie
Copy link

No description provided.

@jlaitine
Copy link

Please note that px4-firmware is a public repository; I believe that this functionality might be part of "TII" proprietary offering, so maybe move the component in a separate git repository. Now this is publicly visible..

bool get_nonce(uint8_t *nonce, size_t *nonce_len);
void close() {}
};
static void sodium_crypto_init(void) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dead code?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed sodium_crypto_init, still kept the sodium crypto functions. Overall the purpose of this Crypto wrapper (Crypto.cpp/hpp) is created mainly for testing without HW.

@kjyrinki-unikie
Copy link
Author

I have moved implementation into separate submodule.

@jlaitine
Copy link

btw. use of exit() is a bit fishy in NuttX context; in case of flat build, there are no processes, so it is not clear what all it wants to kill. If the program has been launched from the terminal (nsh shell), exit() will most likely also kill the shell at the same ;) Also as long as you don't intend to use atexit, you could as well call _exit().

Even though exit() is handy, I would recommend not using exit, but just letting threads run to the end / returning error values to the highest level and returning the error value.

@jlaitine
Copy link

The config.yaml is not added to the ROMFS filesystem anywhere for PX4 build; is this intentional?

AFAIK, there is no clean way to put in files from within module; it will need to be added separately in ROMFS/ build files.

Maybe it is cleaner to make the ports etc. as command line arguments (with some sane defaults hardocoded perhaps), and just skip the yaml file parsing for embedded build ?

Signed-off-by: Jukka Laitinen <[email protected]>
@jlaitine jlaitine force-pushed the DP-7417-secure-mavlink-udp-proxy-cxx branch from adb7632 to 157f4ff Compare November 28, 2023 08:07
@jnippula jnippula force-pushed the DP-7417-secure-mavlink-udp-proxy-cxx branch from e1f1ed4 to ebedb60 Compare November 30, 2023 08:40
@jnippula jnippula force-pushed the DP-7417-secure-mavlink-udp-proxy-cxx branch from 4fb9a06 to 071d32b Compare December 14, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants