Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apdate AOCL to 5.0.0 #102

Open
wants to merge 15 commits into
base: fedora-py3
Choose a base branch
from

Conversation

AlexKurek
Copy link
Contributor

No description provided.

@AlexKurek AlexKurek changed the title Apdate AOCL Apdate AOCL to 5.0.0 Dec 16, 2024
@tikk3r
Copy link
Owner

tikk3r commented Dec 26, 2024

Upgrading to 5.0.0 seems to introduce a noticeable performance regression for WSClean 3.5. I'll put merging this PR on hold until it is clear why or it gets resolved.

wsclean_container_benchmarks_DI_1asec

@tikk3r tikk3r marked this pull request as draft December 26, 2024 13:16
@AlexKurek
Copy link
Contributor Author

Have you also changed this line before benchamrks?

echo source /opt/aocl/4.0/amd-libs.cfg >> $INSTALLDIR/init.sh

I didnt noticed this until now.

@AlexKurek
Copy link
Contributor Author

I just pushed a fix. rm lines also needs fixing, but Im getting:

make[2]: *** No rule to make target '/opt/aocl/5.0.0/aocc/lib/libfftw3f_threads.so', needed by 'scimath/libcasa_scimath.so.8'. Stop.

@AlexKurek
Copy link
Contributor Author

AMD FFTW seems to be already compiled in AOCL. In the logs its after:

Untarring fftw
writing the library: fftw

@AlexKurek
Copy link
Contributor Author

Seems fixed, it does compile at this point.

@tikk3r
Copy link
Owner

tikk3r commented Dec 28, 2024

I just pushed a fix. rm lines also needs fixing, but Im getting:

Yeah I fixed those locally when testing it out.

AMD FFTW seems to be already compiled in AOCL. In the logs its after:

Untarring fftw
writing the library: fftw

It is, but not as a multi-threaded version (at the time).

@AlexKurek AlexKurek marked this pull request as ready for review January 17, 2025 02:34
@AlexKurek
Copy link
Contributor Author

I changed this to ready for review, as it really is, it just needs investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants