Revert rustc version #345
Merged
Revert rustc version #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yang Zhang <[email protected]>
v01dstar
force-pushed
the
revert-rustc-version
branch
from
bb27b29
to
ad87488
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #345 +/- ##
==========================================
- Coverage 98.21% 98.20% -0.01%
==========================================
Files 33 33
Lines 12457 12457
==========================================
- Hits 12235 12234 -1
- Misses 222 223 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yang Zhang <[email protected]>
tonyxuqqi
approved these changes
Dec 12, 2023
|
/merge |
|
Just a nitpick, you should use cargo patch to lock the version of toml to get around this issue. Setting a MSRV lower than actually required is not friendly to potential users. And CI and MSRV must align, that's the point of explicitly setting one in the first place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out it is better to still use rustc 1.66.0, otherwise the downstream TiKV project would require a lot of refactoring works if it wants to update its raft-engine version.
I bumped the version in #343 because
serderequires rustc > 1.67 for stable build. Seems that we get the CI passed, we just need to update the CI's toolchain version, instead of updating the rustc requirement of raft-engine.