Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phonons for all atoms #41

Merged
merged 2 commits into from
Jul 11, 2024
Merged

phonons for all atoms #41

merged 2 commits into from
Jul 11, 2024

Conversation

stan-donarise
Copy link
Contributor

fix #30, #40

nin-jin
nin-jin reviewed Jul 10, 2024
View reviewed changes
player/player.view.web.ts Outdated Show resolved Hide resolved
nin-jin
nin-jin reviewed Jul 10, 2024
View reviewed changes
player/player.view.web.ts Outdated Show resolved Hide resolved
nin-jin
nin-jin reviewed Jul 10, 2024
View reviewed changes
player/player.view.tree
vibrate? null
unvibrate null
phonon? null
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phonon_str может быть?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

не, phonon_str это в $optimade_cifplayer_phonons, а тут phonon который number[][]

@blokhin blokhin linked an issue Jul 10, 2024 that may be closed by this pull request
Phonons should be populated for all the translated or symmetry-recreated atoms #40
Closed
@blokhin blokhin merged commit b4c9bb2 into tilde-lab:master Jul 11, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nin-jin nin-jin nin-jin approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@stan-donarise @nin-jin @blokhin