Selective cperl core cherries 20210408 #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes Coverity CID #165315 Signed-off-by: James E Keenan <[email protected]>
Signed-off-by: James E Keenan <[email protected]>
Said to be needed by Win32 cmd.exe Adapted from timbunce@485d6e2, with one correction.
for all Currently a developer-only test checks Signed-off-by: James E Keenan <[email protected]>
Derived from rurban/75133d3fd0eaf9a8a681d8856ca5fb2438efbfe2.
oodler577
approved these changes
Apr 9, 2021
oodler577
approved these changes
Apr 9, 2021
oodler577
approved these changes
Apr 9, 2021
oodler577
approved these changes
Apr 9, 2021
I tried it with a single |
teodesian
reviewed
Apr 9, 2021
Which |
toddr
reviewed
Apr 12, 2021
| @@ -9,7 +9,7 @@ eval "use autodie; 1" | |||
|
|
|||
| print "autodie $autodie::VERSION $INC{'autodie.pm'}\n"; | |||
|
|
|||
| plan skip_all => "Currently a developer-only test" unless -d '.svn'; | |||
| plan skip_all => "Currently a developer-only test" unless -d '../.git'; | |||
There was a problem hiding this comment.
this doesn't seem right. wouldn't .git be in the current working directory? in which case we'd remove ../
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this pull request is to pick some low-hanging fruit from a larger p.r. submitted in 2019 by @rurban.
3 of the commits are straightforward cherry-picks; 2 required slight corrections or adaptations.
I hope to work through the balance of the 44 commits and incorporate them into thematically grouped pull requests.
Thank you very much.
Jim Keenan