-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Big upgrade and merge of PR #570
Draft
mermetbt
wants to merge
102
commits into
timeoff-management:master
Choose a base branch
from
AlienGen:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…original email ones. Modified calls for emails to add the Slack calls.
…. Added unit test. Moved settings to proper place.
Merging Slack integration.
…tore proper footer. Restore deleted template.
…e. Clean up CSS files. Restore markup on email template.
…and remove console.log on login.js lib file.
…ld to the database schema using the correct tool. This avoids any possible issues for integration with current master and anyone installing the app from scracth.
…mports. Correct sending msg to supervisor twice instead of supervisor and requester on new leave request. Fixed issue on same method on finishing promise.
…ttings not saved when using MySQL (datatype issue).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Thanks for the work done on TimeOff.Management!
Here is the summary of changes:
Theses are breaking changes for current version running on production, I would more consider this as a starting point for a v2.
The code is not stable yet, and I'm still working at fixing remaining issues.