Skip to content

Commit

Permalink
Fix flaky Hypercore join test
Browse files Browse the repository at this point in the history
The join test could sometimes pick a seqscan+sort instead of an
indexscan when doing a MergeAppend+MergeJoin. Disabling seqscan should
make it deterministic.
  • Loading branch information
erimatnor committed Oct 18, 2024
1 parent d643480 commit 0b9db39
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 1 deletion.
2 changes: 2 additions & 0 deletions tsl/test/expected/hypercore_join.out
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,8 @@ select format('%I.%I', chunk_schema, chunk_name)::regclass as chunk2
-- We disable columnar scan for these tests since we have a dedicated
-- test for this.
set timescaledb.enable_columnarscan to false;
-- Discourage seqscan to make sure we predictibly use indexscan
set enable_seqscan to false;
set enable_memoize to false;
-- Create a hypercore with a few rows and use the big table to join
-- with it. This should put the hypercore as the inner relation and
Expand Down
2 changes: 2 additions & 0 deletions tsl/test/sql/hypercore_join.sql
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
-- We disable columnar scan for these tests since we have a dedicated
-- test for this.
set timescaledb.enable_columnarscan to false;
-- Discourage seqscan to make sure we predictibly use indexscan
set enable_seqscan to false;

set enable_memoize to false;

Expand Down
1 change: 0 additions & 1 deletion tsl/test/sql/include/hypercore_join_test.sql
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,3 @@ where r.device_id is distinct from e.device_id;

drop table :inner;
drop table :outer;

0 comments on commit 0b9db39

Please sign in to comment.