Fix filtering of the redundant decompress chunk clauses over a compressed index path #5962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Codecov Report
@@ Coverage Diff @@
## main #5962 +/- ##
==========================================
+ Coverage 86.99% 87.01% +0.01%
==========================================
Files 243 243
Lines 56005 55960 -45
Branches 12401 12384 -17
==========================================
- Hits 48722 48694 -28
+ Misses 4946 4900 -46
- Partials 2337 2366 +29
... and 33 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@RafiaSabih, @jnidzwetzki: please review this pull request.
|
pmwkaa
approved these changes
Aug 15, 2023
jnidzwetzki
reviewed
Aug 15, 2023
| if (is_redundant_derived_clause(rinfo, ipath->indexclauses)) | ||
| continue; /* dup or derived from same EquivalenceClass */ | ||
|
|
||
| ListCell *indexclause_cell = NULL; |
There was a problem hiding this comment.
NIT: Could you add a comment that this code is based on is_redundant_derived_clause but modified for IndexClause? This would make the code easier to read without knowing this change.
jnidzwetzki
approved these changes
Aug 15, 2023
svenklemm
reviewed
Aug 15, 2023
svenklemm
approved these changes
Aug 15, 2023
We just had a bad cast inside is_redundant_derived_clause before, because it doesn't work with IndexClauses. Filtering didn't work as a result.
We used to add join clauses that referenced a compressed column at the level of the compressed scan, and later remove them. This is wrong and useless, just don't add them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We just had a bad cast inside
is_redundant_derived_clausebefore, because it doesn't work withIndexClauses. Filtering didn't work as a result.Disable-check: force-changelog-file
Disable-check: commit-count