Add Ensure to fix coverity defect #7338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7338 +/- ##
==========================================
+ Coverage 80.06% 82.59% +2.52%
==========================================
Files 190 229 +39
Lines 37181 42727 +5546
Branches 9450 10734 +1284
==========================================
+ Hits 29770 35290 +5520
- Misses 2997 3159 +162
+ Partials 4414 4278 -136 ☔ View full report in Codecov by Sentry. |
mkindahl
reviewed
Oct 11, 2024
src/import/ht_hypertable_modify.c
Outdated
Comment on lines
463
to
468
| #if PG17_GE | ||
| if (oldtuple != NULL) | ||
| ExecForceStoreHeapTuple(oldtuple, resultRelInfo->ri_oldTupleSlot, | ||
| false); | ||
| else | ||
| #endif |
There was a problem hiding this comment.
Why was this added? This commit only talks about adding an Ensure.
There was a problem hiding this comment.
Added to match upstream. Let me mention this in the commit message as well for clarity.
There was a problem hiding this comment.
Hmmm... Even those are very simple changes I think it should be splitted into two different PRs:
- with the coverity fix
- with the upstream stuff adding proper PG17 label (it is good to have it separately for future checks)
There was a problem hiding this comment.
I've split this into two PRs.
kpan2034
force-pushed
the
coverity-fix
branch
2 times, most recently
from
c9aa746
to
6c49b66
Compare
fabriziomello
approved these changes
Oct 12, 2024
mkindahl
approved these changes
Oct 14, 2024
svenklemm
approved these changes
Oct 15, 2024
Coverity detected a possible null pointer dereference. It doesn't seem like this can be triggered, so added an `Ensure` clause.
kpan2034
force-pushed
the
coverity-fix
branch
from
6c49b66
to
42c22ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coverity detected a possible null pointer dereference. It doesn't seem like this can be triggered, so added an
Ensureclause.Disable-check: force-changelog-file