Generalise script to create the Changelog PR on main
#7535
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akuzm, @svenklemm: please review this pull request.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7535 +/- ##
==========================================
+ Coverage 80.06% 82.18% +2.11%
==========================================
Files 190 230 +40
Lines 37181 43207 +6026
Branches 9450 10861 +1411
==========================================
+ Hits 29770 35509 +5739
- Misses 2997 3379 +382
+ Partials 4414 4319 -95 ☔ View full report in Codecov by Sentry. |
When the versioned branch, e.g. `2.18.x` is not yet available. This helps to create the Changelog+post-release PR on `main`. Remove a couple of commented lines from the script. Related to issue timescale/eng-database#624
on `main` , as compared to the Release PR on the version-branch , e.g. `2.18.x`.
pallavisontakke
force-pushed
the
generalise-script-for-main-624
branch
from
3ec7e94 to
54026dc
Compare
SC2126 (style): Consider using grep -c instead of grep|wc -l.
SC2016 (info): Expressions don't expand in single quotes, use double quotes for that.
pallavisontakke
changed the title
mainmain
pallavisontakke
changed the title
mainmain
|
Changes from here are now included in another broader #7585 PR. So, closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the minor-version branch, e.g.
2.18.xis not yet available.This way, we can run these steps for a new minor version release:
main,2.18.x, with PRs being created by the same script.
Remove a couple of commented lines from the script.
Related to issue https://github.com/timescale/eng-database/issues/624
Disable-check: force-changelog-file
Disable-check: commit-count