Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector agg: skip entire null words of filter bitmap #7569

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

akuzm
Copy link
Member

@akuzm akuzm commented Jan 6, 2025

This improves the performance for highly selective filters.

This improves the performance for highly selective filters.
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.31%. Comparing base (59f50f2) to head (9b47614).
Report is 688 commits behind head on main.

Files with missing lines Patch % Lines
tsl/src/nodes/vector_agg/grouping_policy_hash.c 86.95% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7569      +/-   ##
==========================================
+ Coverage   80.06%   82.31%   +2.24%     
==========================================
  Files         190      238      +48     
  Lines       37181    43743    +6562     
  Branches     9450    10978    +1528     
==========================================
+ Hits        29770    36005    +6235     
- Misses       2997     3400     +403     
+ Partials     4414     4338      -76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philkra philkra added this to the TimescaleDB 2.18.0 milestone Jan 9, 2025
@akuzm
Copy link
Member Author

akuzm commented Jan 9, 2025

I'll remove it from the 2.18 milestone, because I want to check more things and this optimization is not strictly necessary.

@akuzm akuzm removed this from the TimescaleDB 2.18.0 milestone Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants