Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vectorized hash grouping by a single text column #7586

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

akuzm
Copy link
Member

@akuzm akuzm commented Jan 10, 2025

Use the UMASH hashes that have a guaranteed lower bound on collisions as the hash table keys.

Use the UMASH hashes that have a guaranteed lower bound on collisions as
the hash table keys.
@akuzm akuzm mentioned this pull request Jan 10, 2025
8 tasks
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 50.25554% with 292 lines in your changes missing coverage. Please review.

Project coverage is 81.90%. Comparing base (59f50f2) to head (16d4908).
Report is 688 commits behind head on main.

Files with missing lines Patch % Lines
tsl/src/import/umash.c 45.93% 275 Missing and 11 partials ⚠️
...des/vector_agg/hashing/hash_strategy_single_text.c 88.09% 1 Missing and 4 partials ⚠️
tsl/src/nodes/vector_agg/plan.c 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7586      +/-   ##
==========================================
+ Coverage   80.06%   81.90%   +1.83%     
==========================================
  Files         190      241      +51     
  Lines       37181    44262    +7081     
  Branches     9450    11021    +1571     
==========================================
+ Hits        29770    36251    +6481     
- Misses       2997     3654     +657     
+ Partials     4414     4357      -57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant