Add configurable wait time between restart and preferred leader election #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion. Send elect request only if there are partitions that need leader relections. After reconfiguration, wait for nodes to have SERVING state, rathen than LEADING_ALL_PREFERRED (this is from the proposal PR comment). Refactor tests to reflect the reconfiguration change, and accurately test logging reconfiguration. Signed-off-by: Gantigmaa Selenge <[email protected]>
ShubhamRwt
approved these changes
Jul 8, 2024
ShubhamRwt
reviewed
Jul 8, 2024
| @@ -530,6 +533,7 @@ public static RackRolling rollingRestart(PodOperator podOperator, | |||
| kafkaConfigProvider, | |||
| kafkaLogging, | |||
| postOperationTimeoutMs, | |||
| waitBetweenRestartAndPreferredLeaderElection, | |||
There was a problem hiding this comment.
Just wondering if we can have a smaller name? Something like restartAndPreferredLeaderElectionDelay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This overall addresses strimzi/proposals#103 (comment).
Type of change
Select the type of your PR
Description
Please describe your pull request
Checklist
Please go through this checklist and make sure all applicable tasks have been done