Fix AddSignatureV0 under OpenSSL.

For OpenSSL this didn't return anything. PiperOrigin-RevId: 705543339 Change-Id: Icdce772d2ee61f69044e848f3f0bb386b3435ff9
tink-crypto · Dec 12, 2024 · 45e017e · 45e017e
1 parent c9b005d
commit 45e017e
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 6 deletions.
diff --git a/tink/signature/internal/config_v0.cc b/tink/signature/internal/config_v0.cc
@@ -224,7 +224,7 @@ util::Status AddSignatureV0(Configuration& config) {
   }
 
   // Tink implements PQC signatures with BoringSSL, not OpenSSL.
-  #ifdef OPENSSL_IS_BORINGSSL
+#ifdef OPENSSL_IS_BORINGSSL
   // SLH DSA
   status = RegisterSlhDsaProtoSerialization();
   if (!status.ok()) {
@@ -254,9 +254,14 @@ util::Status AddSignatureV0(Configuration& config) {
   if (!status.ok()) {
     return status;
   }
-  return ConfigurationImpl::AddPrimitiveGetter<PublicKeyVerify, MlDsaPublicKey>(
-      NewMlDsaVerifyBoringSsl, config);
-  #endif
+  status =
+      ConfigurationImpl::AddPrimitiveGetter<PublicKeyVerify, MlDsaPublicKey>(
+          NewMlDsaVerifyBoringSsl, config);
+  if (!status.ok()) {
+    return status;
+  }
+#endif
+  return util::OkStatus();
 }
 
 }  // namespace internal

diff --git a/tink/signature/internal/key_gen_config_v0.cc b/tink/signature/internal/key_gen_config_v0.cc
@@ -83,9 +83,13 @@ util::Status AddSignatureKeyGenV0(KeyGenConfiguration& config) {
   if (!status.ok()) {
     return status;
   }
-  return KeyGenConfigurationImpl::AddKeyCreator<MlDsaParameters>(CreateMlDsaKey,
-                                                                 config);
+  status = KeyGenConfigurationImpl::AddKeyCreator<MlDsaParameters>(
+      CreateMlDsaKey, config);
+  if (!status.ok()) {
+    return status;
+  }
 #endif
+  return util::OkStatus();
 }
 
 }  // namespace internal