Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output structured logs from Gin #279

Merged
merged 1 commit into from
Jul 30, 2023

Conversation

chrisdoherty4
Copy link
Member

@chrisdoherty4 chrisdoherty4 commented Jul 28, 2023

This PR changes Gin to output structured logging instead of its console logging available from gin.Logger() middlware.

In changing to our own middleware implementation we've also removed the dependency on github.com/packethost/pkg.

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #279 (b2e5ad9) into main (cdddec4) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head b2e5ad9 differs from pull request most recent head 51bc99b. Consider uploading reports for the commit 51bc99b to get more accurate results

@@           Coverage Diff           @@
##             main     #279   +/-   ##
=======================================
  Coverage   77.85%   77.85%           
=======================================
  Files          18       18           
  Lines         429      429           
=======================================
  Hits          334      334           
  Misses         82       82           
  Partials       13       13           
Files Changed Coverage Δ
internal/http/serve.go 77.27% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chrisdoherty4 chrisdoherty4 changed the title Change logging implementation to logr with zerolog Output structured logs from Gin Jul 30, 2023
@chrisdoherty4 chrisdoherty4 marked this pull request as ready for review July 30, 2023 21:16
@chrisdoherty4 chrisdoherty4 added the ready-to-merge Signal to Mergify to merge the PR. label Jul 30, 2023
@mergify mergify bot merged commit 65d837a into tinkerbell:main Jul 30, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants