Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace http-port cli arg to http-addr #307

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

chrisdoherty4
Copy link
Member

@chrisdoherty4 chrisdoherty4 commented Oct 16, 2023

Closes #189

http-addr accepts a full address allowing users to bind to a specific IP.

http-addr accepts a full address allowing users to bind to a specific
IP.

Signed-off-by: Chris Doherty <[email protected]>
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #307 (fe61f2a) into main (a2bdac5) will not change coverage.
The diff coverage is n/a.

❗ Current head fe61f2a differs from pull request most recent head d3c2e30. Consider uploading reports for the commit d3c2e30 to get more accurate results

@@           Coverage Diff           @@
##             main     #307   +/-   ##
=======================================
  Coverage   77.85%   77.85%           
=======================================
  Files          18       18           
  Lines         429      429           
=======================================
  Hits          334      334           
  Misses         82       82           
  Partials       13       13           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chrisdoherty4 chrisdoherty4 added the ready-to-merge Signal to Mergify to merge the PR. label Oct 16, 2023
@mergify mergify bot merged commit 36da6b5 into tinkerbell:main Oct 16, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose the full address to listen on as a configuration option
2 participants