[WIP] Add ISO mounting to Workflow boot options #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobweinstock
added
the
do-not-merge
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1008 +/- ##
==========================================
- Coverage 30.06% 28.59% -1.47%
==========================================
Files 71 74 +3
Lines 3739 3840 +101
==========================================
- Hits 1124 1098 -26
- Misses 2539 2665 +126
- Partials 76 77 +1 ☔ View full report in Codecov by Sentry. |
These updates allow for ISO mounting as a boot option. Signed-off-by: Jacob Weinstock <[email protected]>
Use STATE_PREPARING and STATE_POST. This allows us to run operations in a specific order in the state flow. Refactor toggling Hardware allowPXE to be more understandable. Fix deleteExisting. It wasn't deleting existing jobs correctly. Instead of doing a static requeue of 5 seconds, use an exponential backoff. All backoff durations are less than 10seconds. Move condition setting into toggleHardware for consistentcy with the handleJob. Make job.bmc names unique per job type (netboot, iso, etc). Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
force-pushed
the
iso-mounting
branch
from
8d817ba
to
cdd0ad7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a work in progress. Add ISO mounting capabilities to Workflow boot options.
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: