Changed UUID package #285
Merged
Changed UUID package #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaurav Gahlot <[email protected]>
Signed-off-by: Gaurav Gahlot <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #285 +/- ##
==========================================
- Coverage 20.61% 20.58% -0.04%
==========================================
Files 15 15
Lines 1363 1365 +2
==========================================
Hits 281 281
- Misses 1068 1070 +2
Partials 14 14
Continue to review full report at Codecov.
|
gianarb
reviewed
Sep 9, 2020
grpc-server/workflow.go
Outdated
| @@ -33,7 +33,7 @@ func (s *server) CreateWorkflow(ctx context.Context, in *workflow.CreateRequest) | |||
| msg := "" | |||
| labels["op"] = "createworkflow" | |||
| msg = "creating a new workflow" | |||
| id := uuid.NewV4() | |||
| id, _ := uuid.NewUUID() | |||
Signed-off-by: Gaurav Gahlot <[email protected]>
gianarb
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR changes UUID package from
github.com/satori/go.uuidtoto github.com/google/uuid.Why is this needed
The package
github.com/satori/go.uuidis not actively maintained anymore and will eventually be marked as deprecated.References:
How Has This Been Tested?
CI and Tests pass.
How are existing users impacted? What migration steps/scripts do we need?
No impact.
Checklist:
I have: