Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file based agent transport #763

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

chrisdoherty4
Copy link
Member

@chrisdoherty4 chrisdoherty4 commented Jun 22, 2023

This change adds a file based transport that will execute a single workflow. It is useful for testing the agent e2e.

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #763 (d6cee1e) into main (1a0edeb) will decrease coverage by 0.74%.
The diff coverage is 40.00%.

❗ Current head d6cee1e differs from pull request most recent head aaed2e6. Consider uploading reports for the commit aaed2e6 to get more accurate results

@@            Coverage Diff             @@
##             main     #763      +/-   ##
==========================================
- Coverage   51.70%   50.96%   -0.74%     
==========================================
  Files          32       33       +1     
  Lines        1441     1456      +15     
==========================================
- Hits          745      742       -3     
- Misses        655      670      +15     
- Partials       41       44       +3     
Impacted Files Coverage Δ
internal/agent/transport/file.go 40.00% <40.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chrisdoherty4 chrisdoherty4 force-pushed the feature/file-transport branch 2 times, most recently from b3d16cd to 97831a6 Compare June 29, 2023 03:05
@chrisdoherty4 chrisdoherty4 changed the title WIP: Add file based agent transport Add file based agent transport Jun 29, 2023
@chrisdoherty4 chrisdoherty4 marked this pull request as ready for review June 29, 2023 03:08
@chrisdoherty4 chrisdoherty4 force-pushed the feature/file-transport branch 3 times, most recently from 3eb230f to 15d843c Compare July 18, 2023 01:21
@chrisdoherty4
Copy link
Member Author

The previous iteration scanned a directory. However, because the WorkflowHandler does block and there was no tracking of running workflows the implementation would fire all workflows with everything except the first failing.

Given the purpose of this addition is to enable easy e2e testing, I've reduced the implementation to something similar to a suggestion by @jacobweinstock that executes a single file.

Signed-off-by: Chris Doherty <[email protected]>
@chrisdoherty4
Copy link
Member Author

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Jul 18, 2023

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 8ccefc1

@mergify mergify bot merged commit 8ccefc1 into tinkerbell:main Jul 18, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants