Expose stop service advertisment on Windows #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagobagascon
requested changes
Oct 26, 2024
| @@ -49,6 +49,8 @@ func (a *Adapter) AddService(s *Service) error { | |||
| return err | |||
| } | |||
|
|
|||
| a.gattServiceProvider = serviceProvider | |||
There was a problem hiding this comment.
If I understood correctly each GATT service requires its own GattServiceProvider. So if someone adds two services this would only store the latest created.
Users should be able to add and stop the specific service they want.
I was thinking that a map with the UUID and the service provider could work, but the BLE spec allows UUIDs to be repeated (a problem already found on other ble libraries hbldh/bleak#362).
So maybe AddService() should return some handle to the created service to stop it?
There was a problem hiding this comment.
So maybe AddService() should return some handle to the created service to stop it?
That sounds like a very reasonable suggestion!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like you need to call
StopAdvertisingon theGattServiceProviderwhen you want to change the service being advertised or else Windows will just advertise both services. This just exposes that function on the adapter but only for Windows. I added a dummy function on the Linux implementation so apps that use it still build without having to make Linux and Windows specific files.I'm not sure if a Linux implementation is needed or if BlueZ handles this differently.