DOC-2609: Resizing images by typing into the input didn't update the … #3582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…attribute correctly.
abhinavgandham
requested review from
soritaheng,
FarzadHayat,
LewisAtTiny,
kemister85 and
a team
as code owners
abhinavgandham
requested review from
MitchC1999
and removed request for
a team
abhinavgandham
added
the
upcoming release
abhinavgandham
commented
Jan 17, 2025
|
@abhinavgandham You will need to find another name for mce-data as this is used internally only. |
lorenzo-pomili
requested changes
Jan 19, 2025
|
|
||
| This occurred because the resize function was triggered while the selection was elsewhere, due to a debounce delay between the input and the resize operation. As a result, the resize operation was performed on the current selection instead of the intended image. | ||
|
|
||
| This led to other editor components that rely on the `style` attribute accidentally reading outdated values, and the resize not being applied correctly since the selection was not on the image. |
There was a problem hiding this comment.
sorry, this Jira ended having 2 different issues and probably my description was kinda confusing.
the first problem (the one that interfere with the the other editor component) was that updating the width and height via input we didn't update correctly the data-mce-style so some other element, like some plugin, took a non updated value
the second one was about the timeout.
in the Jira documentation the 2 cases are indicated in each section via numbers 1 or 2 when you read 1. [something] that something is referring to the first case and if there is a 2 is referred to the second case.
If you want we can have a call tomorrow morning, I didn't manage this Jira well and there is a little bit of confusion in that documentation :/
There was a problem hiding this comment.
@lorenzo-pomili Yeah sure
abhinavgandham
commented
Jan 21, 2025
lorenzo-pomili
approved these changes
Jan 21, 2025
abhinavgandham
commented
Jan 21, 2025
abhinavgandham
commented
Jan 21, 2025
kemister85
reviewed
Jan 21, 2025
Co-authored-by: Karl Kemister-Sheppard <[email protected]>
kemister85
added a commit
that referenced
this pull request
Jan 22, 2025
#3571) * DOC-2609: TinyMCE 7.6.1 Release Documentation and Community Changelog. * DOC-2609: The mentions menu without items was not closed when pressin… (#3578) * DOC-2609: The mentions menu without items was not closed when pressing Space or Enter key. * Update modules/ROOT/pages/7.6.1-release-notes.adoc * Update modules/ROOT/pages/7.6.1-release-notes.adoc Co-authored-by: Karl Kemister-Sheppard <[email protected]> --------- Co-authored-by: Karl Kemister-Sheppard <[email protected]> * DOC-2609: The mentions dropdown remained visible even after the menti… (#3579) * DOC-2609: The mentions dropdown remained visible even after the mention text was deleted in quick succession. * Update modules/ROOT/pages/7.6.1-release-notes.adoc Co-authored-by: Karl Kemister-Sheppard <[email protected]> * Update modules/ROOT/pages/7.6.1-release-notes.adoc Co-authored-by: Karl Kemister-Sheppard <[email protected]> * Update modules/ROOT/pages/7.6.1-release-notes.adoc Co-authored-by: Karl Kemister-Sheppard <[email protected]> * Update modules/ROOT/pages/7.6.1-release-notes.adoc Co-authored-by: Karl Kemister-Sheppard <[email protected]> --------- Co-authored-by: Karl Kemister-Sheppard <[email protected]> * DOC-2609: Toggle sidebar shortcut remained active when the editor was… (#3580) * DOC-2609: Toggle sidebar shortcut remained active when the editor was disabled. * Update modules/ROOT/pages/7.6.1-release-notes.adoc * Update modules/ROOT/pages/7.6.1-release-notes.adoc Co-authored-by: Karl Kemister-Sheppard <[email protected]> --------- Co-authored-by: Karl Kemister-Sheppard <[email protected]> * DOC-2609: Table resize bars was not properly aligned for inline edito… (#3581) * DOC-2609: Table resize bars was not properly aligned for inline editors inside scrollable containers. * Update modules/ROOT/pages/7.6.1-release-notes.adoc Co-authored-by: Karl Kemister-Sheppard <[email protected]> --------- Co-authored-by: Karl Kemister-Sheppard <[email protected]> * DOC-2609: Images with existing srcset were not handled correctly. (#3583) * DOC-2609: Opening a notification when the toolbar is at the bottom threw an error. (#3586) * DOC-2609: Opening a notification when the toolbar is at the bottom threw an error. * Update modules/ROOT/pages/7.6.1-release-notes.adoc Co-authored-by: Karl Kemister-Sheppard <[email protected]> --------- Co-authored-by: Karl Kemister-Sheppard <[email protected]> * DOC-2609: Text input was prevented in form elements in the contents of the editor. (#3585) * DOC-2609: Text input was prevented in form elements in the contents of the editor. * Update modules/ROOT/pages/7.6.1-release-notes.adoc Co-authored-by: Karl Kemister-Sheppard <[email protected]> * Update modules/ROOT/pages/7.6.1-release-notes.adoc * Update modules/ROOT/pages/7.6.1-release-notes.adoc --------- Co-authored-by: Karl Kemister-Sheppard <[email protected]> * DOC-2609: Error messages were not rendered correctly (#3584) * DOC-2609: Error messages were not rendered correctly * Update modules/ROOT/pages/7.6.1-release-notes.adoc Co-authored-by: Karl Kemister-Sheppard <[email protected]> --------- Co-authored-by: Karl Kemister-Sheppard <[email protected]> * Update modules/ROOT/pages/7.6.1-release-notes.adoc * Update modules/ROOT/pages/7.6.1-release-notes.adoc * Update modules/ROOT/pages/7.6.1-release-notes.adoc * DOC-2609: Resizing images by typing into the input didn't update the … (#3582) * DOC-2609: Resizing images by typing into the input didn't update the attribute correctly. * Update modules/ROOT/pages/7.6.1-release-notes.adoc * Added ticket number to entry. * Improved wording and removed the reference of the attribute's name. * Update modules/ROOT/pages/7.6.1-release-notes.adoc * Update modules/ROOT/pages/7.6.1-release-notes.adoc * Update modules/ROOT/pages/7.6.1-release-notes.adoc * Update modules/ROOT/pages/7.6.1-release-notes.adoc Co-authored-by: Karl Kemister-Sheppard <[email protected]> --------- Co-authored-by: Karl Kemister-Sheppard <[email protected]> * Cleaned up release docs and added security fix and self-hosted server side docs. * Updated changelog * Fixed up changelog to only include titles for core. * fixed up docs entry * API bump and copy edits. --------- Co-authored-by: Karl Kemister-Sheppard <[email protected]>
kemister85
added a commit
that referenced
this pull request
Jan 22, 2025
* DOC-2610: TinyMCE 7.6.1 Release Documentation. * DOC-2609: TinyMCE 7.6.1 Release Documentation and Community Changelog. (#3571) * DOC-2609: TinyMCE 7.6.1 Release Documentation and Community Changelog. * DOC-2609: The mentions menu without items was not closed when pressin… (#3578) * DOC-2609: The mentions menu without items was not closed when pressing Space or Enter key. * Update modules/ROOT/pages/7.6.1-release-notes.adoc * Update modules/ROOT/pages/7.6.1-release-notes.adoc Co-authored-by: Karl Kemister-Sheppard <[email protected]> --------- Co-authored-by: Karl Kemister-Sheppard <[email protected]> * DOC-2609: The mentions dropdown remained visible even after the menti… (#3579) * DOC-2609: The mentions dropdown remained visible even after the mention text was deleted in quick succession. * Update modules/ROOT/pages/7.6.1-release-notes.adoc Co-authored-by: Karl Kemister-Sheppard <[email protected]> * Update modules/ROOT/pages/7.6.1-release-notes.adoc Co-authored-by: Karl Kemister-Sheppard <[email protected]> * Update modules/ROOT/pages/7.6.1-release-notes.adoc Co-authored-by: Karl Kemister-Sheppard <[email protected]> * Update modules/ROOT/pages/7.6.1-release-notes.adoc Co-authored-by: Karl Kemister-Sheppard <[email protected]> --------- Co-authored-by: Karl Kemister-Sheppard <[email protected]> * DOC-2609: Toggle sidebar shortcut remained active when the editor was… (#3580) * DOC-2609: Toggle sidebar shortcut remained active when the editor was disabled. * Update modules/ROOT/pages/7.6.1-release-notes.adoc * Update modules/ROOT/pages/7.6.1-release-notes.adoc Co-authored-by: Karl Kemister-Sheppard <[email protected]> --------- Co-authored-by: Karl Kemister-Sheppard <[email protected]> * DOC-2609: Table resize bars was not properly aligned for inline edito… (#3581) * DOC-2609: Table resize bars was not properly aligned for inline editors inside scrollable containers. * Update modules/ROOT/pages/7.6.1-release-notes.adoc Co-authored-by: Karl Kemister-Sheppard <[email protected]> --------- Co-authored-by: Karl Kemister-Sheppard <[email protected]> * DOC-2609: Images with existing srcset were not handled correctly. (#3583) * DOC-2609: Opening a notification when the toolbar is at the bottom threw an error. (#3586) * DOC-2609: Opening a notification when the toolbar is at the bottom threw an error. * Update modules/ROOT/pages/7.6.1-release-notes.adoc Co-authored-by: Karl Kemister-Sheppard <[email protected]> --------- Co-authored-by: Karl Kemister-Sheppard <[email protected]> * DOC-2609: Text input was prevented in form elements in the contents of the editor. (#3585) * DOC-2609: Text input was prevented in form elements in the contents of the editor. * Update modules/ROOT/pages/7.6.1-release-notes.adoc Co-authored-by: Karl Kemister-Sheppard <[email protected]> * Update modules/ROOT/pages/7.6.1-release-notes.adoc * Update modules/ROOT/pages/7.6.1-release-notes.adoc --------- Co-authored-by: Karl Kemister-Sheppard <[email protected]> * DOC-2609: Error messages were not rendered correctly (#3584) * DOC-2609: Error messages were not rendered correctly * Update modules/ROOT/pages/7.6.1-release-notes.adoc Co-authored-by: Karl Kemister-Sheppard <[email protected]> --------- Co-authored-by: Karl Kemister-Sheppard <[email protected]> * Update modules/ROOT/pages/7.6.1-release-notes.adoc * Update modules/ROOT/pages/7.6.1-release-notes.adoc * Update modules/ROOT/pages/7.6.1-release-notes.adoc * DOC-2609: Resizing images by typing into the input didn't update the … (#3582) * DOC-2609: Resizing images by typing into the input didn't update the attribute correctly. * Update modules/ROOT/pages/7.6.1-release-notes.adoc * Added ticket number to entry. * Improved wording and removed the reference of the attribute's name. * Update modules/ROOT/pages/7.6.1-release-notes.adoc * Update modules/ROOT/pages/7.6.1-release-notes.adoc * Update modules/ROOT/pages/7.6.1-release-notes.adoc * Update modules/ROOT/pages/7.6.1-release-notes.adoc Co-authored-by: Karl Kemister-Sheppard <[email protected]> --------- Co-authored-by: Karl Kemister-Sheppard <[email protected]> * Cleaned up release docs and added security fix and self-hosted server side docs. * Updated changelog * Fixed up changelog to only include titles for core. * fixed up docs entry * API bump and copy edits. --------- Co-authored-by: Karl Kemister-Sheppard <[email protected]> --------- Co-authored-by: Karl Kemister-Sheppard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… attribute correctly.
Ticket: DOC-2609
Site: Staging branch
Changes:
Pre-checks:
feature/<version>/,hotfix/<version>/,staging/<version>/, orrelease/<version>/.Review: