-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: multi screen window show #450
Open
AkaShark
wants to merge
13
commits into
tisfeng:dev
Choose a base branch
from
AkaShark:fix/show_window_multi_screen
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+61
−3
Open
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
6284df2
fix: multi screen window show
AkaShark 2862567
Merge branch 'dev' into fix/show_window_multi_screen
tisfeng cdc0b9d
fix: remove option multi screen type
AkaShark 1485220
Merge branch 'fix/show_window_multi_screen' of github.com:AkaShark/Ea…
AkaShark 7ba23ed
fix: remove option multi screen type
AkaShark c04a1bd
feat: add record for start query screen
AkaShark 68b2648
feat: remove start query screen when floating window close
AkaShark 8346158
remove blank line
AkaShark 77c821d
Merge branch 'dev' into fix/show_window_multi_screen
tisfeng 9a7fc36
pref: record screen using selection translation by Accessibility
AkaShark 74515c9
pref: record screen using selection translation by apple script
AkaShark 3fee003
Merge branch 'dev' into fix/show_window_multi_screen
AkaShark 5c5e4f0
Merge branch 'dev' into fix/show_window_multi_screen
AkaShark File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletions
36
Easydict/NewApp/Utility/Extensions/WindowMultiScreenTypeExtensions.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
// | ||
// WindowMultiScreenTypeExtensions.swift | ||
// Easydict | ||
// | ||
// Created by Sharker on 2024/3/10. | ||
// Copyright © 2024 izual. All rights reserved. | ||
// | ||
|
||
import Defaults | ||
import Foundation | ||
|
||
// MARK: - EZShowWindowMultiScreen + Defaults.Serializable | ||
|
||
extension EZShowWindowMultiScreen: Defaults.Serializable {} | ||
|
||
// MARK: - EZShowWindowMultiScreen + CaseIterable | ||
|
||
extension EZShowWindowMultiScreen: CaseIterable { | ||
public static let allCases: [EZShowWindowMultiScreen] = [.auto, .fixed] | ||
} | ||
|
||
// MARK: - EZShowWindowMultiScreen + CustomLocalizedStringResourceConvertible | ||
|
||
@available(macOS 13, *) | ||
extension EZShowWindowMultiScreen: CustomLocalizedStringResourceConvertible { | ||
public var localizedStringResource: LocalizedStringResource { | ||
switch self { | ||
case .auto: | ||
"show_window_multi_screen_auto" | ||
case .fixed: | ||
"show_window_multi_screen_fixed" | ||
@unknown default: | ||
"unknown_option" | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it should not use mainScreen here, it should use the screen when selecting words.