-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI revamp for tin #13
Conversation
67f2be1
to
9a29936
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! It looks a lot better than it does right now :). My one concern (which permeates through the comments I've left below) is the fact that important fields are tucked away into collapsed sections.
Currently, I think it's fine for all fields to be expanded by default (we've got enough screen real estate). However, this may change after #9, so make sure you're not counting on it.
Therefore, a structural revamp of AssignmentForm.sections
might be necessary for better organization. I've also talked about that below.
92dac97
to
853a0e9
Compare
I've left it so that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! The backend implementation looks solid. I've got a few (minor) UI changes, though:
An interesting side-effect of your change is that resizing the description textarea now looks weird if it extends into the right column. So, I'd recommend the following textarea changes alongside this PR:
- Limit its max resize width to the width of the column div (I believe
max-width: 90%
should be close enough) - Set it to max width by default (
width: 90%
?) - Make it a bit taller to use more free space (17rows/300px seems reasonable)
Additionally, these:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make it such that I can click the submit button on the assignment creation screen without expanding stuff thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing progress! The box shadow is a great touch.
A few more UI bugs/improvements:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my latest commit - it's not perfect by any means, but it's what I could get in ~30 minutes.
I'll approve the PR so you can merge it in when ready, but feel free to test out my changes and make additional ones as you see fit.
Currently a WIP.
Hopefully resolves #10