Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI revamp for tin #13

Merged
merged 4 commits into from
May 12, 2024
Merged

UI revamp for tin #13

merged 4 commits into from
May 12, 2024

Conversation

JasonGrace2282
Copy link
Member

@JasonGrace2282 JasonGrace2282 commented May 5, 2024

Currently a WIP.

Hopefully resolves #10

@JasonGrace2282 JasonGrace2282 force-pushed the ui-revamp branch 2 times, most recently from 67f2be1 to 9a29936 Compare May 5, 2024 16:34
@JasonGrace2282
Copy link
Member Author

JasonGrace2282 commented May 5, 2024

image
Marking this as Ready for Review, unless I think of some better thing to do.

@JasonGrace2282 JasonGrace2282 marked this pull request as ready for review May 5, 2024 20:19
@JasonGrace2282 JasonGrace2282 requested a review from a team as a code owner May 5, 2024 20:19
Copy link
Member

@krishnans2006 krishnans2006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! It looks a lot better than it does right now :). My one concern (which permeates through the comments I've left below) is the fact that important fields are tucked away into collapsed sections.

Currently, I think it's fine for all fields to be expanded by default (we've got enough screen real estate). However, this may change after #9, so make sure you're not counting on it.

Therefore, a structural revamp of AssignmentForm.sections might be necessary for better organization. I've also talked about that below.

tin/apps/assignments/forms.py Outdated Show resolved Hide resolved
tin/apps/assignments/forms.py Outdated Show resolved Hide resolved
tin/apps/assignments/templatetags/index.py Outdated Show resolved Hide resolved
tin/static/css/edit.css Show resolved Hide resolved
@JasonGrace2282 JasonGrace2282 force-pushed the ui-revamp branch 3 times, most recently from 92dac97 to 853a0e9 Compare May 8, 2024 18:11
@JasonGrace2282
Copy link
Member Author

I've left it so that Environment Setup is open by default (looks better that way imo).
In terms of looks and colors, I'm not very good with that xD. Do you have any ideas on how you might want it to look?

Copy link
Member

@krishnans2006 krishnans2006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! The backend implementation looks solid. I've got a few (minor) UI changes, though:

An interesting side-effect of your change is that resizing the description textarea now looks weird if it extends into the right column. So, I'd recommend the following textarea changes alongside this PR:

  • Limit its max resize width to the width of the column div (I believe max-width: 90% should be close enough)
  • Set it to max width by default (width: 90%?)
  • Make it a bit taller to use more free space (17rows/300px seems reasonable)

Additionally, these:

tin/templates/assignments/edit_create.html Outdated Show resolved Hide resolved
tin/templates/assignments/edit_create.html Outdated Show resolved Hide resolved
tin/templates/assignments/edit_create.html Outdated Show resolved Hide resolved
tin/templates/assignments/edit_create.html Show resolved Hide resolved
Copy link

@ksquaring ksquaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make it such that I can click the submit button on the assignment creation screen without expanding stuff thank you

Copy link
Member

@krishnans2006 krishnans2006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing progress! The box shadow is a great touch.

A few more UI bugs/improvements:

tin/static/css/edit.css Show resolved Hide resolved
tin/static/css/edit.css Show resolved Hide resolved
tin/static/css/edit.css Show resolved Hide resolved
tin/static/css/edit.css Outdated Show resolved Hide resolved
Copy link
Member

@krishnans2006 krishnans2006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my latest commit - it's not perfect by any means, but it's what I could get in ~30 minutes.

I'll approve the PR so you can merge it in when ready, but feel free to test out my changes and make additional ones as you see fit.

@krishnans2006 krishnans2006 merged commit 72d0153 into tjcsl:master May 12, 2024
1 check passed
@JasonGrace2282 JasonGrace2282 deleted the ui-revamp branch May 12, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve assignment create/edit form
3 participants