Add autocomplete to Text form for submissions. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishnans2006
requested changes
May 13, 2024
There was a problem hiding this comment.
The autocompletion works perfectly! To summarize our conversations, I think a few changes should be made to the underlying feature:
- Non-quiz assignments (anything using
submit.html) should have autocomplete always enabled (after all, students can just use an IDE here) - Quizzes should have this feature implemented as opt-in. However, this may require a restructuring of
assignments.models.Quiz, which is still an ongoing discussion.
Therefore, for now, just adding this feature to submit.html without any database changes should suffice.
krishnans2006
approved these changes
May 17, 2024
JasonGrace2282
changed the title
krishnans2006
added a commit
that referenced
this pull request
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just found out about this ace feature, seemed cool. However, for classes like Foundations of Computer Science, an opt-out procedure wouldn't be desirable as people are still trying to learn syntax at that point. As such, it's opt-in.
Also changed
aceto use cdnjs (part of #18 )