Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add numbering to course students #78

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

JasonGrace2282
Copy link
Member

@JasonGrace2282 JasonGrace2282 commented Aug 27, 2024

  • Explicitly order names by first name, in case of a last name conflict (EDIT: Removed from PR)
    • The way to sort stuff in cases of identical values is not in the SQL specification, so we can't rely on that sorting a specific way.
  • Adds a counter to the names (see below)

image

Also adds a counter to the names
@JasonGrace2282 JasonGrace2282 added the enhancement New feature or request label Aug 27, 2024
@JasonGrace2282 JasonGrace2282 self-assigned this Aug 27, 2024
@JasonGrace2282 JasonGrace2282 requested a review from a team as a code owner August 27, 2024 22:13
@JasonGrace2282 JasonGrace2282 changed the title Explicitly order names after last name conflict Add numbering to course students Sep 4, 2024
Copy link
Member

@alanzhu0 alanzhu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash commits

@krishnans2006
Copy link
Member

Please squash commits

@alanzhu0 that isn't necessary for Tin, since it uses a squash and merge workflow.

Copy link
Member

@krishnans2006 krishnans2006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only worry is that these two tables aren't the only ones that would benefit from numbering (as in, it's better to number every table of students than it is to just number two specific tables on a certain page). I'll take a look soon and let you know whether this is an actual change request or just a hallucination :)

@JasonGrace2282 JasonGrace2282 dismissed alanzhu0’s stale review September 16, 2024 16:23

Left comments not applicable to Tin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants