-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add numbering to course students #78
base: master
Are you sure you want to change the base?
Conversation
JasonGrace2282
commented
Aug 27, 2024
•
edited
Loading
edited
- Explicitly order names by first name, in case of a last name conflict (EDIT: Removed from PR)
- The way to sort stuff in cases of identical values is not in the SQL specification, so we can't rely on that sorting a specific way.
- Adds a counter to the names (see below)
Also adds a counter to the names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash commits
@alanzhu0 that isn't necessary for Tin, since it uses a squash and merge workflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only worry is that these two tables aren't the only ones that would benefit from numbering (as in, it's better to number every table of students than it is to just number two specific tables on a certain page). I'll take a look soon and let you know whether this is an actual change request or just a hallucination :)
Left comments not applicable to Tin