Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve instructions for dev env #86

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Improve instructions for dev env #86

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5db11b1
Bugfixes to get a working dev env
JasonGrace2282 Sep 10, 2024
56abebc
Remove platform-dependent yap
JasonGrace2282 Sep 10, 2024
17ffe76
pathlibify
JasonGrace2282 Sep 10, 2024
3d94f55
use sys.executable instead of or-ring shutil.which
JasonGrace2282 Sep 11, 2024
8cce7ae
Use formatting python instead of sys.executable
JasonGrace2282 Sep 11, 2024
8e02041
Make stuff more robust
JasonGrace2282 Sep 11, 2024
ed80196
Update implementation of create_debug_users
JasonGrace2282 Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tin/apps/submissions/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import shutil
import signal
import subprocess
import sys
import time
import traceback
from decimal import Decimal
Expand Down Expand Up @@ -65,8 +66,8 @@ def run_submission(submission_id):
if submission.assignment.venv_fully_created:
python_exe = os.path.join(submission.assignment.venv.path, "bin", "python")
elif settings.DEBUG:
python_exe = shutil.which("python") or shutil.which("python3")
else:
python_exe = sys.executable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart!

else: # pragma: no cover
python_exe = "/usr/bin/python3.10"

if not settings.DEBUG or shutil.which("bwrap") is not None:
Expand Down
Loading